[webkit-changes] [WebKit/WebKit] aeae68: Convert scroll-padding/scroll-margin types to stro...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aeae68feccffa4d8156c4bb28abd04e2d967f43f
      https://github.com/WebKit/WebKit/commit/aeae68feccffa4d8156c4bb28abd04e2d967f43f
  Author: Sam Weinig <sam at webkit.org>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/values/CSSValueAggregates.h
    M Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleBuilderCustom.h
    A Source/WebCore/style/values/scroll-snap/StyleScrollMargin.cpp
    A Source/WebCore/style/values/scroll-snap/StyleScrollMargin.h
    A Source/WebCore/style/values/scroll-snap/StyleScrollPadding.cpp
    A Source/WebCore/style/values/scroll-snap/StyleScrollPadding.h

  Log Message:
  -----------
  Convert scroll-padding/scroll-margin types to strongly typed Style values
https://bugs.webkit.org/show_bug.cgi?id=286867

Reviewed by Antti Koivisto.

Partially re-applies a simplified version of 288829 at main.

This version wraps WebCore::Length values rather than trying to
to build these new value types on top of CompactVariant. With this
in place, we can work on updating the implementation with much more
targeted changes.

This change also only updates the Style type, leaving the CSS
type alone for now.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/ViewTimeline.cpp:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
* Source/WebCore/css/values/CSSValueAggregates.h:
* Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderElement.cpp:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleBuilderCustom.h:
* Source/WebCore/style/values/scroll-snap/StyleScrollMargin.cpp: Added.
* Source/WebCore/style/values/scroll-snap/StyleScrollMargin.h: Added.
* Source/WebCore/style/values/scroll-snap/StyleScrollPadding.cpp: Added.
* Source/WebCore/style/values/scroll-snap/StyleScrollPadding.h: Added.

Canonical link: https://commits.webkit.org/289829@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications