[webkit-changes] [WebKit/WebKit] bb2b67: Web Inspector: remove frontend and backend support...

Blaze Jayne noreply at github.com
Tue Feb 4 13:01:21 PST 2025 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb2b6735bb3443035edbee7ad712aa4c3a25fa5d
      https://github.com/WebKit/WebKit/commit/bb2b6735bb3443035edbee7ad712aa4c3a25fa5d
  Author: BJ Burg <bburg at apple.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/JavaScriptCore/DerivedSources-input.xcfilelist
    M Source/JavaScriptCore/DerivedSources.make
    R Source/JavaScriptCore/inspector/protocol/ApplicationCache.json
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/inspector/InspectorController.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.h
    R Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.cpp
    R Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.h
    M Source/WebCore/loader/appcache/ApplicationCacheHost.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Base/Main.js
    R Source/WebInspectorUI/UserInterface/Controllers/ApplicationCacheManager.js
    M Source/WebInspectorUI/UserInterface/Images/TableIcons.svg
    M Source/WebInspectorUI/UserInterface/Main.html
    R Source/WebInspectorUI/UserInterface/Models/ApplicationCacheFrame.js
    R Source/WebInspectorUI/UserInterface/Models/ApplicationCacheManifest.js
    M Source/WebInspectorUI/UserInterface/Models/ConsoleMessage.js
    M Source/WebInspectorUI/UserInterface/Models/IssueMessage.js
    M Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js
    R Source/WebInspectorUI/UserInterface/Protocol/ApplicationCacheObserver.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.5/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.3/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.3/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Target.js
    M Source/WebInspectorUI/UserInterface/Test.html
    M Source/WebInspectorUI/UserInterface/Test/Test.js
    R Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js
    R Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.css
    R Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js
    R Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js
    R Source/WebInspectorUI/UserInterface/Views/ApplicationCacheManifestTreeElement.js
    M Source/WebInspectorUI/UserInterface/Views/ContentView.js
    M Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
    M Source/WebInspectorUI/UserInterface/Views/StorageIcons.css
    M Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js
    M Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js
    M Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-12.2.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-13.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-13.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-14.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-14.5.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-15.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-15.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-16.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-16.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-17.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-17.2.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-17.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-18.2.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-12.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-12.3.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-13.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-13.3.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-14.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-14.2.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-14.4.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-15.2.json

  Log Message:
  -----------
  Web Inspector: remove frontend and backend support for ApplicationCache
rdar://143596399
https://bugs.webkit.org/show_bug.cgi?id=286641

Reviewed by Devin Rousso and Sihui Liu.

Application Cache has been deprecated for many releases, so we don't need to
keep carrying this little-used capability into the future. Rather than port this
domain to work with cross-origin iframes, let's remove it.

This domain never had any layout tests associated with it, so there are no deleted tests.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/DerivedSources-input.xcfilelist:
* Source/JavaScriptCore/DerivedSources.make:
* Source/JavaScriptCore/inspector/protocol/ApplicationCache.json: Removed.
* Source/WebCore/Sources.txt:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/inspector/InspectorController.cpp:
(WebCore::InspectorController::createLazyAgents):
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::networkStateChangedImpl): Deleted.
(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): Deleted.
* Source/WebCore/inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::networkStateChanged): Deleted.
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Deleted.
* Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.cpp: Removed.
* Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.h: Removed.
* Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::swapCache):
* Source/WebCore/page/Page.cpp:
(WebCore::networkStateChanged):
* Source/WebInspectorUI/UserInterface/Base/Main.js:
(WI.loaded):
* Source/WebInspectorUI/UserInterface/Controllers/ApplicationCacheManager.js: Removed.
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Main.html:
* Source/WebInspectorUI/UserInterface/Models/ApplicationCacheFrame.js: Removed.
* Source/WebInspectorUI/UserInterface/Models/ApplicationCacheManifest.js: Removed.
* Source/WebInspectorUI/UserInterface/Images/TableIcons.svg:
* Source/WebInspectorUI/UserInterface/Models/ConsoleMessage.js:
* Source/WebInspectorUI/UserInterface/Models/IssueMessage.js:
* Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:
* Source/WebInspectorUI/UserInterface/Protocol/ApplicationCacheObserver.js: Removed.
* Source/WebInspectorUI/UserInterface/Test.html:
* Source/WebInspectorUI/UserInterface/Test/Test.js:
(WI.loaded):
(WI.contentLoaded):
* Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.css: Removed.
* Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/ApplicationCacheManifestTreeElement.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.isViewable):
* Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
* Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel):
(WI.StorageSidebarPanel.prototype.closed):
(WI.StorageSidebarPanel._treeSelectionDidChange):
(WI.StorageSidebarPanel.prototype._frameManifestAdded): Deleted.
(WI.StorageSidebarPanel.prototype._addFrameManifest): Deleted.
(WI.StorageSidebarPanel.prototype._frameManifestRemoved): Deleted.
(WI.StorageSidebarPanel.prototype._applicationCacheCleared): Deleted.
* Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js:
(WI.StorageTabContentView):
(WI.StorageTabContentView.isTabAllowed):
(WI.StorageTabContentView.prototype.canShowRepresentedObject):
(WI.StorageTabContentView.prototype.closed):

* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.5/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.3/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.3/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-12.2.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-13.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-13.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-14.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-14.5.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-15.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-15.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-16.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-16.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-17.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-17.2.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-17.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-18.2.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-12.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-12.3.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-13.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-13.3.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-14.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-14.2.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-14.4.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-15.2.json:
Remove ApplicationCache domain from versioned protocol files so we don't try to set up observers and managers.

Canonical link: https://commits.webkit.org/289820@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list