[webkit-changes] [WebKit/WebKit] 7c5689: [iOS] REGRESSION(288610 at main): Captions disappear ...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c5689faf8d70da36afcea0de61021824bb4ee86
      https://github.com/WebKit/WebKit/commit/7c5689faf8d70da36afcea0de61021824bb4ee86
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.h
    M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm

  Log Message:
  -----------
  [iOS] REGRESSION(288610 at main): Captions disappear in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=287027
rdar://144114434

Reviewed by Eric Carlson.

When 288610 at main moved ownership of WebAVPlayerLayer out of the model
and into the interface, it ended up confusing which WebAVPlayerLayer
was being referred to by the playerLayer() method. Add a new
fullscreenPlayerLayer() method and refer to it when setting up
fullscreen (including the fullscreen playerLayer's caption layer).

* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.h:
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm:
(WebCore::VideoPresentationInterfaceAVKitLegacy::setupFullscreen):
(WebCore::VideoPresentationInterfaceAVKitLegacy::fullscreenPlayerLayer const):

Canonical link: https://commits.webkit.org/289818@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications