[webkit-changes] [WebKit/WebKit] c2b3cb: Resuming an interrupted `git webkit pr` produces a...

Brianna Fan noreply at github.com
Tue Feb 4 10:44:33 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2b3cb0e470b3a305b95c7c82557390653433235
      https://github.com/WebKit/WebKit/commit/c2b3cb0e470b3a305b95c7c82557390653433235
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M Tools/Scripts/hooks/prepare-commit-msg
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/commit.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py

  Log Message:
  -----------
  Resuming an interrupted `git webkit pr` produces a commit message without links
rdar://125444927
https://bugs.webkit.org/show_bug.cgi?id=271279

Reviewed by Jonathan Bedard.

When creating a commit in program.commit or program.pull_request, we shouldn't
set env variables if the bug title and urls are null.

If these are empty, we check for the variables stored in the branch config.

* Tools/Scripts/hooks/prepare-commit-msg:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/commit.py:
(Commit.main):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_commit):

Canonical link: https://commits.webkit.org/289804@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list