[webkit-changes] [WebKit/WebKit] 3f2b71: [Win] Disable the debug CRT assert dialog

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f2b714b495e853b00c9687f1a979af349bbd903
      https://github.com/WebKit/WebKit/commit/3f2b714b495e853b00c9687f1a979af349bbd903
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M Source/JavaScriptCore/jsc.cpp
    M Source/JavaScriptCore/testRegExp.cpp
    M Source/WTF/wtf/PlatformWin.cmake
    A Source/WTF/wtf/win/WTFCRTDebug.cpp
    A Source/WTF/wtf/win/WTFCRTDebug.h
    M Source/WebKit/Shared/AuxiliaryProcess.cpp
    M Source/WebKit/Shared/win/AuxiliaryProcessMainWin.cpp
    M Tools/WebKitTestRunner/win/TestControllerWin.cpp

  Log Message:
  -----------
  [Win] Disable the debug CRT assert dialog
https://bugs.webkit.org/show_bug.cgi?id=286947

Reviewed by Don Olmstead.

<https://webkit.org/b/282800> is going to use the debug CRT for
Windows debug builds. If an assertion fails in STL, the debug assert
dialog pops up while running layout tests.

<https://commits.webkit.org/11943@main> added _CrtSetReportMode call
to jsc.cpp to suppress the dialog.

Added WTF::disableCRTDebugAssertDialog() by extracting the code from
jsc.cpp. And, call it from all executables.

* Source/JavaScriptCore/jsc.cpp:
(main):
* Source/JavaScriptCore/testRegExp.cpp:
(main):
* Source/WTF/wtf/PlatformWin.cmake:
* Source/WTF/wtf/win/WTFCRTDebug.cpp: Added.
(WTF::disableCRTDebugAssertDialog):
* Source/WTF/wtf/win/WTFCRTDebug.h: Added.
* Source/WebKit/Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::platformInitialize): Deleted.
* Source/WebKit/Shared/win/AuxiliaryProcessMainWin.cpp:
(WebKit::AuxiliaryProcess::platformInitialize):
* Tools/WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize):

Canonical link: https://commits.webkit.org/289795@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications