[webkit-changes] [WebKit/WebKit] f347ac: Fix unsafe casts to JSVMClientData reported by sta...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f347acbdaa0e30cad83a712f3bfe014cf2bc21f0
      https://github.com/WebKit/WebKit/commit/f347acbdaa0e30cad83a712f3bfe014cf2bc21f0
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result
    M Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result
    M Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result
    M Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result
    M Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result
    M Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result
    M Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result
    M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py
    M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_templates.py
    M Source/JavaScriptCore/runtime/VM.h
    M Source/WebCore/Modules/streams/TransformStream.cpp
    M Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M Source/WebCore/bindings/js/DOMWrapperWorld.cpp
    M Source/WebCore/bindings/js/InternalReadableStream.cpp
    M Source/WebCore/bindings/js/InternalWritableStream.cpp
    M Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp
    M Source/WebCore/bindings/js/JSDOMConstructorBase.cpp
    M Source/WebCore/bindings/js/JSDOMConstructorNotCallable.h
    M Source/WebCore/bindings/js/JSDOMWindowBase.cpp
    M Source/WebCore/bindings/js/JSDOMWindowProperties.cpp
    M Source/WebCore/bindings/js/JSEventListener.cpp
    M Source/WebCore/bindings/js/JSIDBSerializationGlobalObject.cpp
    M Source/WebCore/bindings/js/JSObservableArray.cpp
    M Source/WebCore/bindings/js/JSWindowProxy.cpp
    M Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp
    M Source/WebCore/bindings/js/ScriptController.cpp
    M Source/WebCore/bindings/js/WebCoreJSClientData.h
    M Source/WebCore/bridge/runtime_array.cpp
    M Source/WebCore/bridge/runtime_method.cpp
    M Source/WebCore/bridge/runtime_object.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp

  Log Message:
  -----------
  Fix unsafe casts to JSVMClientData reported by static analysis
https://bugs.webkit.org/show_bug.cgi?id=286984

Reviewed by Ryosuke Niwa.

* Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
* Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
* Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
* Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
* Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
* Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
* Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result:
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py:
(BuiltinsInternalsWrapperImplementationGenerator._generate_initialize_static_globals):
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_templates.py:
* Source/JavaScriptCore/runtime/VM.h:
(JSC::VM::ClientData::isWebCoreJSClientData const):
* Source/WebCore/Modules/streams/TransformStream.cpp:
(WebCore::createInternalTransformStream):
* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
* Source/WebCore/bindings/js/InternalReadableStream.cpp:
(WebCore::InternalReadableStream::createFromUnderlyingSource):
(WebCore::InternalReadableStream::isLocked const):
(WebCore::InternalReadableStream::isDisturbed const):
(WebCore::InternalReadableStream::lock):
(WebCore::InternalReadableStream::pipeTo):
(WebCore::InternalReadableStream::cancel):
(WebCore::InternalReadableStream::getReader):
(WebCore::InternalReadableStream::pipeThrough):
(WebCore::InternalReadableStream::tee):
* Source/WebCore/bindings/js/InternalWritableStream.cpp:
(WebCore::InternalWritableStream::writeChunkForBingings):
(WebCore::InternalWritableStream::createFromUnderlyingSink):
(WebCore::InternalWritableStream::locked const):
(WebCore::InternalWritableStream::lock):
(WebCore::InternalWritableStream::abortForBindings):
(WebCore::InternalWritableStream::closeForBindings):
(WebCore::InternalWritableStream::closeIfPossible):
(WebCore::InternalWritableStream::getWriter):
* Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp:
(WebCore::JSDOMBuiltinConstructorBase::subspaceForImpl):
* Source/WebCore/bindings/js/JSDOMConstructorBase.cpp:
(WebCore::JSDOMConstructorBase::subspaceForImpl):
* Source/WebCore/bindings/js/JSDOMConstructorNotCallable.h:
(WebCore::JSDOMConstructorNotCallable::subspaceFor):
* Source/WebCore/bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
* Source/WebCore/bindings/js/JSDOMWindowProperties.cpp:
(WebCore::JSDOMWindowProperties::subspaceForImpl):
* Source/WebCore/bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
* Source/WebCore/bindings/js/JSIDBSerializationGlobalObject.cpp:
(WebCore::JSIDBSerializationGlobalObject::subspaceForImpl):
* Source/WebCore/bindings/js/JSObservableArray.cpp:
(JSC::JSObservableArray::subspaceForImpl):
* Source/WebCore/bindings/js/JSWindowProxy.cpp:
(WebCore::JSWindowProxy::subspaceForImpl):
* Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp:
(WebCore::ReadableStreamDefaultController::close):
(WebCore::ReadableStreamDefaultController::error):
(WebCore::ReadableStreamDefaultController::enqueue):
* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
* Source/WebCore/bindings/js/WebCoreJSClientData.h:
(isType):
(WebCore::subspaceForImpl):
(WebCore::builtinNames):
* Source/WebCore/bridge/runtime_array.cpp:
(JSC::RuntimeArray::subspaceForImpl):
* Source/WebCore/bridge/runtime_method.cpp:
(JSC::RuntimeMethod::subspaceForImpl):
* Source/WebCore/bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::subspaceForImpl):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::serviceWorkerGlobalObject):
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::notifyServiceWorkerPageOfCreationIfNecessary):

Canonical link: https://commits.webkit.org/289792@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications