[webkit-changes] [WebKit/WebKit] e4a6a6: REGRESSION (276904 at main): Breaks https://www.tax.n...

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4a6a6964d558f0b1e57d779a325b46a9c3bc2d1
      https://github.com/WebKit/WebKit/commit/e4a6a6964d558f0b1e57d779a325b46a9c3bc2d1
  Author: Yijia Huang <hyjorc1 at gmail.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    A JSTests/stress/function-toString-for-accessor-properties.js
    M JSTests/test262/expectations.yaml
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt
    M LayoutTests/js/basic-strict-mode-expected.txt
    M LayoutTests/js/dom/native-bindings-descriptors-expected.txt
    M LayoutTests/js/dom/native-bindings-descriptors.html
    M LayoutTests/js/script-tests/basic-strict-mode.js
    M LayoutTests/js/script-tests/function-toString-vs-name.js
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt
    M Source/JavaScriptCore/runtime/JSCustomGetterFunction.cpp
    M Source/JavaScriptCore/runtime/JSCustomSetterFunction.cpp

  Log Message:
  -----------
  REGRESSION (276904 at main): Breaks https://www.tax.ny.gov/online/.
https://bugs.webkit.org/show_bug.cgi?id=274224
rdar://128149232

Reviewed by Yusuke Suzuki.

Previously, we reverted the changes[1] that fixed the getter function
string to align with the spec because they caused an issue on this website.
It seems the website developer has fixed the issue. Therefore, let's
re-land the changes.

[1]
- https://commits.webkit.org/276904@main
- https://commits.webkit.org/277023@main

* JSTests/stress/function-toString-for-accessor-properties.js: Added.
(assertNativeGetter):
(assertNativeSetter):
(wellKnownIntrinsicObjects.forEach):
* JSTests/test262/expectations.yaml:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt:
* LayoutTests/js/basic-strict-mode-expected.txt:
* LayoutTests/js/dom/native-bindings-descriptors-expected.txt:
* LayoutTests/js/dom/native-bindings-descriptors.html:
* LayoutTests/js/script-tests/basic-strict-mode.js:
* LayoutTests/js/script-tests/function-toString-vs-name.js:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt:
* Source/JavaScriptCore/runtime/JSCustomGetterFunction.cpp:
(JSC::JSCustomGetterFunction::create):
* Source/JavaScriptCore/runtime/JSCustomSetterFunction.cpp:
(JSC::JSCustomSetterFunction::create):

Canonical link: https://commits.webkit.org/289786@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications