[webkit-changes] [WebKit/WebKit] 089129: [Grid] Incorrectly cached enclosing fragmented flo...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0891297fda32eb9bfdba3d81e4abf0a6f1647383
      https://github.com/WebKit/WebKit/commit/0891297fda32eb9bfdba3d81e4abf0a6f1647383
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    A LayoutTests/fast/grid/grid-crash-inside-fragmentation-expected.txt
    A LayoutTests/fast/grid/grid-crash-inside-fragmentation.html
    M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  -----------
  [Grid] Incorrectly cached enclosing fragmented flow may cause crash
https://bugs.webkit.org/show_bug.cgi?id=286980
<rdar://144091757>

Reviewed by Antti Koivisto.

locateEnclosingFragmentedFlow is supposed to be called with the intent of caching the result
as the valid enclosing fragmented flow. This function just wants to check if there's
an enclosing fragmented flow. Let's call enclosingFragmentedFlow instead.

* LayoutTests/fast/grid/grid-crash-inside-fragmentation-expected.txt: Added.
* LayoutTests/fast/grid/grid-crash-inside-fragmentation.html: Added.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::canCreateIntrinsicLogicalHeightsForRowSizingFirstPassCache const):

Canonical link: https://commits.webkit.org/289779@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications