[webkit-changes] [WebKit/WebKit] 43e213: Improve snappedSelectionRect parameters

[fantasai]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43e213f4cdb0c3675e27188cf17874bfbc4978ae
      https://github.com/WebKit/WebKit/commit/43e213f4cdb0c3675e27188cf17874bfbc4978ae
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2025-02-03 (Mon, 03 Feb 2025)

  Changed paths:
    M Source/WebCore/rendering/LegacyInlineTextBox.cpp
    M Source/WebCore/rendering/LegacyInlineTextBox.h
    M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  -----------
  Improve snappedSelectionRect parameters
https://bugs.webkit.org/show_bug.cgi?id=286964
rdar://144117546

Reviewed by Alan Baradlay.

Remove redundant selectionTop and selectionHeight parameters, and pass
a WritingMode object instead of a boolean.

* Source/WebCore/rendering/LegacyInlineTextBox.cpp:
(WebCore::snappedSelectionRect):
(WebCore::LegacyInlineTextBox::localSelectionRect const):
* Source/WebCore/rendering/LegacyInlineTextBox.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::selectionRectForTextBox):
(WebCore::characterRects):

Canonical link: https://commits.webkit.org/289768@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications