[webkit-changes] [WebKit/WebKit] 8fa2c4: Minor TextBoxPainter optimizations

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8fa2c44953aea49cda4a24ed83b4213f24e351dd
      https://github.com/WebKit/WebKit/commit/8fa2c44953aea49cda4a24ed83b4213f24e351dd
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2025-02-03 (Mon, 03 Feb 2025)

  Changed paths:
    M Source/WebCore/rendering/TextBoxPainter.cpp
    M Source/WebCore/rendering/TextBoxPainter.h

  Log Message:
  -----------
  Minor TextBoxPainter optimizations
https://bugs.webkit.org/show_bug.cgi?id=286869
rdar://144025111

Reviewed by Tim Nguyen.

Avoid fetching `m_renderer.frame().editor()` twice in the TextBoxPainter constructor, and in
`paintCompositionForeground()` when we don't need to paint composition highlights.

* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::m_emphasisMarkExistsAndIsAbove):
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
(WebCore::TextBoxPainter::~TextBoxPainter): Deleted.
* Source/WebCore/rendering/TextBoxPainter.h:

Canonical link: https://commits.webkit.org/289745@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications