[webkit-changes] [WebKit/WebKit] 75ec68: Fixes Model Process resources deallocation.

[Alex Marchenko]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75ec68cfc5a707e4ec0d559131519403bd5c744c
      https://github.com/WebKit/WebKit/commit/75ec68cfc5a707e4ec0d559131519403bd5c744c
  Author: Aleksei Marchenko <aleksei at apple.com>
  Date:   2025-02-03 (Mon, 03 Feb 2025)

  Changed paths:
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
    M Source/WebKit/ModelProcess/cocoa/WKModelProcessModelLayer.h
    M Source/WebKit/ModelProcess/cocoa/WKModelProcessModelLayer.mm

  Log Message:
  -----------
  Fixes Model Process resources deallocation.
https://bugs.webkit.org/show_bug.cgi?id=286817
rdar://138060013

Reviewed by Ada Chan.

A combination of fixes that guaranties memory deallocation used
for HTMLModelElement rendering.

Combined changes:
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::~HTMLModelElement):
Explicitly calls deleteModelPlayer() in element's destructor to signal to
Model Process.

* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::~ModelProcessModelPlayerProxy):
(WebKit::ModelProcessModelPlayerProxy::createLayer):
(WebKit::ModelProcessModelPlayerProxy::didFinishLoading):
For manually created entities (REEntityCreate() call) adds calls of
REEntityRemoveFromSceneOrParent() to release them.

* Source/WebKit/ModelProcess/cocoa/WKModelProcessModelLayer.h:
* Source/WebKit/ModelProcess/cocoa/WKModelProcessModelLayer.mm:
(-[WKModelProcessModelLayer setPlayer:]):
(-[WKModelProcessModelLayer player]):
(-[WKModelProcessModelLayer setOpacity:]):
(-[WKModelProcessModelLayer layoutSublayers]):
Breaks cyclic dependency between ModelProcessModelPlayerProxy and
WKModelProcessModelLayer. Now the layer has WeakPtr to the player.

Canonical link: https://commits.webkit.org/289741@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications