[webkit-changes] [WebKit/WebKit] 5853b8: Adopt smart pointers in WebKit/UIProcess/BrowsingC...

Frédéric Wang noreply at github.com
Mon Feb 3 07:59:44 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5853b8960b6d05972aef970edf40c4fc26f1d2a0
      https://github.com/WebKit/WebKit/commit/5853b8960b6d05972aef970edf40c4fc26f1d2a0
  Author: Frédéric Wang <fwang at igalia.com>
  Date:   2025-02-03 (Mon, 03 Feb 2025)

  Changed paths:
    M Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/UIProcess/BrowsingContextGroup.cpp

  Log Message:
  -----------
  Adopt smart pointers in WebKit/UIProcess/BrowsingContextGroup.cpp
https://bugs.webkit.org/show_bug.cgi?id=286810

Reviewed by Chris Dumez.

* Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: Remove expectation.
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: Ditto.
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::ensureProcessForConnection): FrameProcess::create() is non trivial, use protected version of WebPageProxy::legacyMainFrameProcess() as the WebProcessProxy argument.
(WebKit::BrowsingContextGroup::addFrameProcess): RemotePageProxy::create() is non trivial, hold a smart pointer to WebPageProxy and WebProcessProxy arguments.
(WebKit::BrowsingContextGroup::addPage): RemotePageProxy::create() is non trivial, hold a smart pointer to WebProcessProxy argument.
(WebKit::BrowsingContextGroup::takeRemotePageInProcessForProvisionalPage): HashSet::take() is non trivial, so hold a smart pointer to remotePage.
(WebKit::BrowsingContextGroup::transitionPageToRemotePage): RemotePageProxy::create() is non trivial, use protected version of WebPageProxy::legacyMainFrameProcess() as the WebProcessProxy argument.
(WebKit::BrowsingContextGroup::transitionProvisionalPageToRemotePage):
WeakHashMap::ensure is not trivial, use protected version of ProvisionalPageProxy::page().
RemotePageProxy::create() is non trivial, use protected version of WebPageProxy::process() as the WebProcessProxy argument.

Canonical link: https://commits.webkit.org/289735@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list