[webkit-changes] [WebKit/WebKit] 6003ad: [Cleanup] Remove unused RenderText::m_linesDirty

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6003ad5df844c5e760cc94f8790b119cabef1126
      https://github.com/WebKit/WebKit/commit/6003ad5df844c5e760cc94f8790b119cabef1126
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-02-02 (Sun, 02 Feb 2025)

  Changed paths:
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderInline.h
    M Source/WebCore/rendering/RenderMenuList.cpp
    M Source/WebCore/rendering/RenderQuote.cpp
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderText.h
    M Source/WebCore/rendering/RenderTextLineBoxes.cpp
    M Source/WebCore/rendering/RenderTextLineBoxes.h
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  -----------
  [Cleanup] Remove unused RenderText::m_linesDirty
https://bugs.webkit.org/show_bug.cgi?id=286872

Reviewed by Antti Koivisto.

1. Remove redundant (non-svg) dirtyLegacyLineBoxes calls
2. dirtyLegacyLineBoxes is now always called with fullLayout 'true' -> m_linesDirty becomes redundant
3. RenderText::setTextWithOffset is always called with force=false; remove the function argument.

* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::deleteLegacyLineBoxes):
(WebCore::RenderInline::dirtyLegacyLineBoxes): Deleted.
(WebCore::RenderInline::deleteLegacyLines): Deleted.
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderMenuList.cpp:
(RenderMenuList::setText):
* Source/WebCore/rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateTextRenderer):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::dirtyLegacyLineBoxes): Deleted.
(WebCore::RenderText::usesLegacyLineLayoutPath const): Deleted.
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::createInlineTextBox):
* Source/WebCore/rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::dirtyForTextChange):
* Source/WebCore/rendering/RenderTextLineBoxes.h:
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateTextRenderer):

Canonical link: https://commits.webkit.org/289711@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications