[webkit-changes] [WebKit/WebKit] 2a34f2: [WebGPU] Infinite loop forward progress detection ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a34f2731ad7c6a003d78e788249cf75744f9a7d
      https://github.com/WebKit/WebKit/commit/2a34f2731ad7c6a003d78e788249cf75744f9a7d
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-02-02 (Sun, 02 Feb 2025)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-286820-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-286820.html
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WebGPU] Infinite loop forward progress detection leads to problematic codegen
https://bugs.webkit.org/show_bug.cgi?id=286820
rdar://143899010

Reviewed by Cameron McCormack.

The UB loop detection was insufficient to prevent against unwanted compiler
optimizations.

By mirroring WebGL we see the UB issues in this repro and others addressed.

* LayoutTests/fast/webgpu/nocrash/fuzz-286820-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-286820.html: Added.
Regression test must be run locally as compute shaders which run
infinite loops do not terminate on macOS without boot-args set.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/289703@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications