[webkit-changes] [WebKit/WebKit] 2f2b93: Serialize `font-style: oblique 0` as `normal`

Sam Weinig noreply at github.com
Sun Feb 2 08:47:26 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f2b93f73c368cc0216e37a4d07ab2238295b15a
      https://github.com/WebKit/WebKit/commit/2f2b93f73c368cc0216e37a4d07ab2238295b15a
  Author: Sam Weinig <sam at webkit.org>
  Date:   2025-02-02 (Sun, 02 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-style-interpolation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-style-interpolation.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-style-parsing.html
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/css/CSSFontStyleWithAngleValue.cpp
    M Source/WebCore/css/CSSFontStyleWithAngleValue.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp
    M Source/WebCore/editing/EditingStyle.cpp
    M Source/WebCore/style/StyleResolveForFont.cpp
    M Source/WebCore/style/StyleResolveForFont.h

  Log Message:
  -----------
  Serialize `font-style: oblique 0` as `normal`
https://bugs.webkit.org/show_bug.cgi?id=286863

Reviewed by Tim Nguyen.

Per resolution of https://github.com/w3c/csswg-drafts/issues/11430,
`font-style: oblique 0` should serialize as `normal`.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-style-interpolation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-style-interpolation.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-style-parsing.html:
    - Update WPT tests and expectations with new behavior.

* Source/WebCore/css/CSSFontStyleWithAngleValue.cpp:
* Source/WebCore/css/CSSFontStyleWithAngleValue.h:
    - Replace internal CSSPrimitiveValue with a CSS::Angle<-90,90>
      to automatically perform range clamping on resolution of calc.
    - Update serialization to special case known zero.

* Source/WebCore/css/ComputedStyleExtractor.cpp:
    - Update to create a CSS::Angle as the inner value.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp:
* Source/WebCore/editing/EditingStyle.cpp:
* Source/WebCore/style/StyleResolveForFont.cpp:
* Source/WebCore/style/StyleResolveForFont.h:
    - Add support for resolving new representation of CSSFontStyleWithAngleValue.

Canonical link: https://commits.webkit.org/289699@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list