[webkit-changes] [WebKit/WebKit] ab8ed3: Update command invokers to match spec changes

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab8ed368b438f0cc82180066a6d85eacb02f4930
      https://github.com/WebKit/WebKit/commit/ab8ed368b438f0cc82180066a6d85eacb02f4930
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2025-02-01 (Sat, 01 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-event-dispatch.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/event-dispatch-shadow.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/event-interface.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/idlharness.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-invalid-behavior.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-popover-behavior.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-popover-invalid-behavior.tentative-expected.txt
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/dom/CommandEvent.cpp
    M Source/WebCore/dom/CommandEvent.h
    M Source/WebCore/dom/CommandEvent.idl
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/html/HTMLButtonElement.cpp
    M Source/WebCore/html/HTMLButtonElement.h
    M Source/WebCore/html/HTMLButtonElement.idl
    M Source/WebCore/html/HTMLFormControlElement.cpp
    M Source/WebCore/html/HTMLFormControlElement.h
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLInputElement.idl
    R Source/WebCore/html/InvokerElement.idl

  Log Message:
  -----------
  Update command invokers to match spec changes
https://bugs.webkit.org/show_bug.cgi?id=286764

Reviewed by Tim Nguyen.

- Commands are now kebab cased and custom commands now start with "--".

- The CommandEvent's invoker property was renamed to source.

- command/commandfor now only work on button elements, support for input buttons was removed.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/button-event-dispatch.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/event-dispatch-shadow.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/event-interface.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/idlharness.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-invalid-behavior.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-popover-behavior.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-popover-invalid-behavior.tentative-expected.txt:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/dom/CommandEvent.cpp:
(WebCore::CommandEvent::CommandEvent):
(WebCore::CommandEvent::source const):
(WebCore::CommandEvent::invoker const): Deleted.
* Source/WebCore/dom/CommandEvent.h:
* Source/WebCore/dom/CommandEvent.idl:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::handlePopoverLightDismiss):
* Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::commandForElement const):
(WebCore::HTMLButtonElement::commandType const):
(WebCore::HTMLButtonElement::handleCommand):
* Source/WebCore/html/HTMLButtonElement.h:
* Source/WebCore/html/HTMLButtonElement.idl:
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::commandForElement const): Deleted.
(WebCore::HTMLFormControlElement::commandType const): Deleted.
(WebCore::HTMLFormControlElement::handleCommand): Deleted.
* Source/WebCore/html/HTMLFormControlElement.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* Source/WebCore/html/HTMLInputElement.idl:
* Source/WebCore/html/InvokerElement.idl: Removed.

Canonical link: https://commits.webkit.org/289681@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications