[webkit-changes] [WebKit/WebKit] 1b97d0: check-webkit-style should skip *.py files under La...

Fujii Hironori noreply at github.com
Mon Sep 30 13:51:39 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b97d0c6ae2e7e17b66ab0161fb518fd9b1fde05
      https://github.com/WebKit/WebKit/commit/1b97d0c6ae2e7e17b66ab0161fb518fd9b1fde05
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/style/checker.py
    M Tools/Scripts/webkitpy/style/checker_unittest.py

  Log Message:
  -----------
  check-webkit-style should skip *.py files under LayoutTests/imported directory
https://bugs.webkit.org/show_bug.cgi?id=274407

Reviewed by Jonathan Bedard.

check-webkit-style reported errors for *.py files under
web-platform-tests directory. It should ignore *.py files under
LayoutTests/imported directory.

_NEVER_SKIPPED_FILES contained a regexp
"re.compile('(?!WebDriverTests).{0,14}.*.py$')" which matches all py
files under all directory but `WebDriverTests`.

Changed it to a regexp matches *.py files udner `LayoutTests` directory
but not followed by `imported`.

* Tools/Scripts/webkitpy/style/checker.py:
* Tools/Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherSkipTest.test_should_skip_without_warning__true):

Canonical link: https://commits.webkit.org/284464@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list