[webkit-changes] [WebKit/WebKit] a585b0: REGRESSION(247615 at main): [WPE][GTK] Suspended cach...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a585b00cb55e2ef5c0fb3d897618214f42f33d82
      https://github.com/WebKit/WebKit/commit/a585b00cb55e2ef5c0fb3d897618214f42f33d82
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp

  Log Message:
  -----------
  REGRESSION(247615 at main): [WPE][GTK] Suspended cached web processes remain forever after UI process terminates uncleanly
https://bugs.webkit.org/show_bug.cgi?id=280014

Reviewed by Carlos Garcia Campos.

Give up on suspending cached web processes. Hopefully the impact on
battery life is not too great. :(

Resume relies on the UI process to not crash, and UI process crashes are
unfortunately common. My suggestion is to introduce a new process
monitor auxiliary process to manage terminating and reaping all other
auxiliary processes when the UI process terminates, but that requires
effort. In the meantime, Ctrl+C is all it takes to test what happens
when the UI process "crashes" or quits uncleanly. We need to make sure
all subprocesses are reliably terminated even when this happens. The
auxiliary process is normally able to notice when its IPC connection to
the UI process is closed, and then quit. But it cannot notice if it is
suspended!

* Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):

Canonical link: https://commits.webkit.org/284462@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications