[webkit-changes] [WebKit/WebKit] 92e73b: Fix ARMv7 C ABI for Int64s

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92e73bdff695fa2d3a6250ab4828a845878465b3
      https://github.com/WebKit/WebKit/commit/92e73bdff695fa2d3a6250ab4828a845878465b3
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/b3/B3LowerInt64.cpp
    M Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp
    M Source/JavaScriptCore/b3/air/AirCCallingConvention.h

  Log Message:
  -----------
  Fix ARMv7 C ABI for Int64s
https://bugs.webkit.org/show_bug.cgi?id=279974

Reviewed by Justin Michaud.

On ARMv7, Int64 arguments need to be passed on even register pairs (so,
r0/r1 or r2/r3, but not r1/r2). Pass in dummy Int32 arguments in
LowerInt64 so that AirCCallingConvention.cpp does not have to know about
the provenance of Int32 arguments and whether they were originally part
of an Int64.

* Source/JavaScriptCore/b3/B3CCallValue.h:
* Source/JavaScriptCore/b3/B3LowerInt64.cpp:
* Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp:
(JSC::B3::Air::computeCCallingConvention):
(JSC::B3::Air::computeCCallArguments):

Canonical link: https://commits.webkit.org/284451@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications