[webkit-changes] [WebKit/WebKit] 12b70e: [EWS macOS] imported/w3c/web-platform-tests/web-an...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12b70e251e35902a59d671d4170e9d38841f87df
      https://github.com/WebKit/WebKit/commit/12b70e251e35902a59d671d4170e9d38841f87df
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/animation/AnimationPlaybackEvent.cpp
    M Source/WebCore/animation/AnimationPlaybackEvent.h
    M Source/WebCore/animation/AnimationPlaybackEvent.idl
    M Source/WebCore/animation/CSSNumberishTime.cpp
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h

  Log Message:
  -----------
  [EWS macOS] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/document-timelines.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=280528
rdar://136843486

Reviewed by Antti Koivisto.

Ensure that when a CSSNumberishTime is converted automatically to an API-facing type,
either `double` or `CSSNumberish`, we go through the `secondsToWebAnimationsAPITime`
utility to round the time value per https://drafts.csswg.org/web-animations-1/#precision-of-time-values.

This allows us to remove some bindings-specific code as well, which is how this bug
surfaced in the first place with 284168 at main.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/animation/AnimationPlaybackEvent.cpp:
(WebCore::AnimationPlaybackEvent::bindingsCurrentTime const): Deleted.
(WebCore::AnimationPlaybackEvent::bindingsTimelineTime const): Deleted.
* Source/WebCore/animation/AnimationPlaybackEvent.h:
* Source/WebCore/animation/AnimationPlaybackEvent.idl:
* Source/WebCore/animation/CSSNumberishTime.cpp:
(WebCore::CSSNumberishTime::operator double const):
(WebCore::CSSNumberishTime::operator CSSNumberish const):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::bindingsStartTime const): Deleted.
(WebCore::WebAnimation::bindingsCurrentTime const): Deleted.
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::bindingsCurrentTime const):

Canonical link: https://commits.webkit.org/284448@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications