[webkit-changes] [WebKit/WebKit] 9a109e: [UnifiedPDF][iOS] Show find indicator for the curr...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a109e4656341e3e8e19621125dd918afa1a139b
      https://github.com/WebKit/WebKit/commit/9a109e4656341e3e8e19621125dd918afa1a139b
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-09-29 (Sun, 29 Sep 2024)

  Changed paths:
    M Source/WebCore/page/Chrome.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp
    M Source/WebKit/WebProcess/Plugins/PluginView.h
    M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp
    M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.h

  Log Message:
  -----------
  [UnifiedPDF][iOS] Show find indicator for the current match
https://bugs.webkit.org/show_bug.cgi?id=280574
rdar://136903474

Reviewed by Wenson Hsieh.

Create and display a text indicator for the current match. Additionally, scroll
to reveal the current match as it is changed.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::textIndicatorForTextMatch):
(WebKit::PDFPluginBase::scrollToRevealTextMatch):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::scrollToRevealTextMatch):

On iOS, the native scroll view must be scrolled to reveal the current match.

(WebKit::UnifiedPDFPlugin::textIndicatorForTextMatch):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::textIndicatorForTextMatch):
(WebKit::PluginView::scrollToRevealTextMatch):
* Source/WebKit/WebProcess/Plugins/PluginView.h:
* Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::decorateTextRangeWithStyle):
(WebKit::WebFoundTextRangeController::scrollTextRangeToVisible):
(WebKit::WebFoundTextRangeController::redraw):
(WebKit::WebFoundTextRangeController::createTextIndicatorForPDFRange):
(WebKit::WebFoundTextRangeController::setTextIndicatorWithPDFRange):
(WebKit::WebFoundTextRangeController::flashTextIndicatorAndUpdateSelectionWithPDFRange):
(WebKit::WebFoundTextRangeController::rectsForTextMatchesInRect):

Do not paint a hole for the current match.

(WebKit::WebFoundTextRangeController::frameForFoundTextRange const):

Factor out common logic to determine the local frame for a match.

(WebKit::WebFoundTextRangeController::documentForFoundTextRange const):
* Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.h:

Canonical link: https://commits.webkit.org/284437@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications