[webkit-changes] [WebKit/WebKit] 81b009: Add a test for the `buttonNumber` and `modifierFla...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81b0097021b1003a3942a1b470bf750a846e3b45
      https://github.com/WebKit/WebKit/commit/81b0097021b1003a3942a1b470bf750a846e3b45
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-09-28 (Sat, 28 Sep 2024)

  Changed paths:
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm
    M Tools/TestWebKitAPI/cocoa/TestDownloadDelegate.mm
    A Tools/TestWebKitAPI/ios/IOSMouseEventTestHarness.h
    A Tools/TestWebKitAPI/ios/IOSMouseEventTestHarness.mm

  Log Message:
  -----------
  Add a test for the `buttonNumber` and `modifierFlags` properties of `WKNavigationAction`
https://bugs.webkit.org/show_bug.cgi?id=280569
rdar://136894323

Reviewed by Wenson Hsieh.

There isn't an existing test for the `buttonNumber` and `modifierFlags` properties of `WKNavigationAction`,
so this PR adds one.

To facilitate this, the `MouseEventTestHarness` helper class is factored out to a new file so that it can
be re-used in multiple files.

* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:
(TEST(WKNavigationAction, UserInputState)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
(TEST(iOSMouseSupport, DoNotChangeSelectionWithRightClick)):
(TEST(iOSMouseSupport, RightClickDoesNotShowMenuIfPreventDefault)):
(TEST(iOSMouseSupport, TrackButtonMaskFromTouchStart)):
(TEST(iOSMouseSupport, MouseTimestampTimebase)):
(TEST(iOSMouseSupport, EndedTouchesTriggerClick)):
(TEST(iOSMouseSupport, CancelledTouchesDoNotTriggerClick)):
(TEST(iOSMouseSupport, MouseDidMoveOverElement)):
(TEST(iOSMouseSupport, WebsiteMouseEventPolicies)):
(-[WKTestingTouch locationInView:]): Deleted.
(-[WKTestingTouch setLocationInView:]): Deleted.
(-[WKTestingTouch setTapCount:]): Deleted.
(-[WKTestingTouch setPhase:]): Deleted.
(-[WKTestingTouch phase]): Deleted.
(-[WKTestingTouch tapCount]): Deleted.
(-[WKTestingTouch timestamp]): Deleted.
(-[WKTestingTouch _isPointerTouch]): Deleted.
(TestWebKitAPI::MouseEventTestHarness::MouseEventTestHarness): Deleted.
(TestWebKitAPI::MouseEventTestHarness::mouseMove): Deleted.
(TestWebKitAPI::MouseEventTestHarness::mouseDown): Deleted.
(TestWebKitAPI::MouseEventTestHarness::mouseUp): Deleted.
(TestWebKitAPI::MouseEventTestHarness::mouseCancel): Deleted.
(TestWebKitAPI::MouseEventTestHarness::activeTouches const): Deleted.
(TestWebKitAPI::MouseEventTestHarness::webView const): Deleted.
(TestWebKitAPI::MouseEventTestHarness::mouseInteraction const): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, DoNotChangeSelectionWithRightClick)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, RightClickOutsideOfTextNodeDoesNotSelect)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, RightClickDoesNotShowMenuIfPreventDefault)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, TrackButtonMaskFromTouchStart)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, MouseTimestampTimebase)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, EndedTouchesTriggerClick)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, CancelledTouchesDoNotTriggerClick)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, MouseDidMoveOverElement)): Deleted.
(TestWebKitAPI::handleUpdatedSelection): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, SelectionUpdatesBeforeContextMenuAppears)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, DisablingTextIteractionPreventsSelectionWhenShowingContextMenu)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, ShowingContextMenuSelectsEditableText)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, ShowingContextMenuSelectsNonEditableText)): Deleted.
(TestWebKitAPI::simulateEditContextMenuAppearance): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, ContextClickAtEndOfSelection)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, WebsiteMouseEventPolicies)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, MouseInitiallyDisconnected)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, MouseInitiallyConnected)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, MouseLaterDisconnected)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, MouseLaterConnected)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, MouseAlwaysConnected)): Deleted.
(TestWebKitAPI::TEST(iOSMouseSupport, BasicPointerInteractionRegions)): Deleted.
* Tools/TestWebKitAPI/cocoa/IOSMouseEventTestHarness.h: Added.
(TestWebKitAPI::MouseEventTestHarness::activeTouches const):
(TestWebKitAPI::MouseEventTestHarness::webView const):
(TestWebKitAPI::MouseEventTestHarness::mouseInteraction const):
* Tools/TestWebKitAPI/cocoa/IOSMouseEventTestHarness.mm: Added.
(-[WKTestingTouch locationInView:]):
(-[WKTestingTouch setLocationInView:]):
(-[WKTestingTouch setTapCount:]):
(-[WKTestingTouch setPhase:]):
(-[WKTestingTouch phase]):
(-[WKTestingTouch tapCount]):
(-[WKTestingTouch timestamp]):
(-[WKTestingTouch _isPointerTouch]):
(TestWebKitAPI::MouseEventTestHarness::MouseEventTestHarness):
(TestWebKitAPI::MouseEventTestHarness::mouseMove):
(TestWebKitAPI::MouseEventTestHarness::mouseDown):
(TestWebKitAPI::MouseEventTestHarness::mouseUp):
(TestWebKitAPI::MouseEventTestHarness::mouseCancel):
* Tools/TestWebKitAPI/cocoa/TestDownloadDelegate.mm:

Canonical link: https://commits.webkit.org/284425@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications