[webkit-changes] [WebKit/WebKit] 6584bb: Forward WebContent logs to the UI process

Per Arne Vollan noreply at github.com
Sat Sep 28 04:50:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6584bb248cb9520297d961cad4f5b7f5aec35386
      https://github.com/WebKit/WebKit/commit/6584bb248cb9520297d961cad4f5b7f5aec35386
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-09-28 (Sat, 28 Sep 2024)

  Changed paths:
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    R Source/WebKit/NetworkProcess/LogStream.cpp
    R Source/WebKit/NetworkProcess/LogStream.h
    R Source/WebKit/NetworkProcess/LogStream.messages.in
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    A Source/WebKit/Shared/LogStream.cpp
    A Source/WebKit/Shared/LogStream.h
    A Source/WebKit/Shared/LogStream.messages.in
    M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebProcessProxy.messages.in
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  Forward WebContent logs to the UI process
https://bugs.webkit.org/show_bug.cgi?id=278022
rdar://133759441

Reviewed by Chris Dumez.

In order to address quarantine issues with forwarding to the Networking process, forward WebContent logs to the UI process instead.
This will attribute the WebContent logs to a large number of UI processes, instead of to the single Networking process.

* Source/WebKit/NetworkProcess/LogStream.cpp:
(WebKit::LogStream::logOnBehalfOfWebContent):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::setupLogStream): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/Shared/LogStream.cpp: Renamed from Source/WebKit/NetworkProcess/LogStream.cpp.
(WebKit::LogStream::~LogStream):
(WebKit::LogStream::logOnBehalfOfWebContent):
(WebKit::LogStream::setup):
* Source/WebKit/Shared/LogStream.h: Renamed from Source/WebKit/NetworkProcess/LogStream.h.
* Source/WebKit/Shared/LogStream.messages.in: Renamed from Source/WebKit/NetworkProcess/LogStream.messages.in.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::setupLogStream):
(WebKit::WebProcessProxy::logOnBehalfOfWebContent): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::setupLogStream):

Canonical link: https://commits.webkit.org/284411@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list