[webkit-changes] [WebKit/WebKit] b62c28: Add watchtime logging for buffering stall events

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b62c284f1d1879a6e678df78197f03801553fcb5
      https://github.com/WebKit/WebKit/commit/b62c284f1d1879a6e678df78197f03801553fcb5
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/page/DiagnosticLoggingKeys.cpp
    M Source/WebCore/page/DiagnosticLoggingKeys.h

  Log Message:
  -----------
  Add watchtime logging for buffering stall events
https://bugs.webkit.org/show_bug.cgi?id=280408
rdar://136754786

Reviewed by Eric Carlson.

Add logging which tracks stall events, their duration, and which media loading source was being used at the time.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::updateBufferingState):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::watchtimeTimerFired):
(WebCore::HTMLMediaElement::startBufferingStopwatch):
(WebCore::HTMLMediaElement::invalidateBufferingStopwatch):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mediaBufferingWatchTimeKey):
* Source/WebCore/page/DiagnosticLoggingKeys.h:

Canonical link: https://commits.webkit.org/284404@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications