[webkit-changes] [WebKit/WebKit] 8581b6: [IFC][Bidi] Empty inline box does not generate val...

Vitaly Dyachkov noreply at github.com
Fri Sep 27 18:23:34 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8581b67df6d8ab1326d7b351dd5ad5a731372951
      https://github.com/WebKit/WebKit/commit/8581b67df6d8ab1326d7b351dd5ad5a731372951
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/css3/unicode-bidi-float-crash.html
    A LayoutTests/platform/glib/css3/unicode-bidi-float-crash-expected.txt
    A LayoutTests/platform/ios/css3/unicode-bidi-float-crash-expected.txt
    A LayoutTests/platform/mac/css3/unicode-bidi-float-crash-expected.txt
    A LayoutTests/platform/win/css3/unicode-bidi-float-crash-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp

  Log Message:
  -----------
  [IFC][Bidi] Empty inline box does not generate valid geometry
https://bugs.webkit.org/show_bug.cgi?id=266537

Reviewed by Alan Baradlay.

An inline box containing only a float should not be considered as contentful.

* LayoutTests/TestExpectations:
* LayoutTests/css3/unicode-bidi-float-crash.html: Added.
* LayoutTests/platform/glib/css3/unicode-bidi-float-crash-expected.txt: Added.
* LayoutTests/platform/ios/css3/unicode-bidi-float-crash-expected.txt: Added.
* LayoutTests/platform/mac/css3/unicode-bidi-float-crash-expected.txt: Added.
* LayoutTests/platform/win/css3/unicode-bidi-float-crash-expected.txt: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

Canonical link: https://commits.webkit.org/284402@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list