[webkit-changes] [WebKit/WebKit] 0eadc6: [IsDeprecatedWeakRefSmartPointerException] Make Pa...

[Basuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0eadc6960dc578b3e8c3cc5a7bbcda543ccd0876
      https://github.com/WebKit/WebKit/commit/0eadc6960dc578b3e8c3cc5a7bbcda543ccd0876
  Author: Basuke Suzuki <basuke at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm
    M Source/WebKit/UIProcess/API/Cocoa/PageLoadStateObserver.h
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/Cocoa/NavigationState.h
    M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
    M Source/WebKit/UIProcess/PageLoadState.cpp
    M Source/WebKit/UIProcess/PageLoadState.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  -----------
  [IsDeprecatedWeakRefSmartPointerException] Make PageLoadState and related classes RefCounted or equivalent
https://bugs.webkit.org/show_bug.cgi?id=280282

Reviewed by Chris Dumez.

Those classes are CanMakeWeakPtr so that need to be lifecycle manageable.

* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPageStateClient):
* Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm:
(-[WKObservablePageState initWithPage:]):
* Source/WebKit/UIProcess/API/Cocoa/PageLoadStateObserver.h:
* Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController _initWithPageRef:]):
(WebKit::PageLoadStateObserver::ref const):
(WebKit::PageLoadStateObserver::deref const):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkitWebViewDispose):
* Source/WebKit/UIProcess/Cocoa/NavigationState.h:
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::ref const):
(WebKit::NavigationState::deref const):
* Source/WebKit/UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::callObserverCallback):
* Source/WebKit/UIProcess/PageLoadState.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setPageLoadStateObserver):
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/284380@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications