[webkit-changes] [WebKit/WebKit] b8a516: AX: AXIsolatedTree::firstMarker should be construc...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8a516d7b28caa8059fccb036c8df935b4dcb75b
      https://github.com/WebKit/WebKit/commit/b8a516d7b28caa8059fccb036c8df935b4dcb75b
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: AXIsolatedTree::firstMarker should be constructed from the web area object
https://bugs.webkit.org/show_bug.cgi?id=280488
rdar://136793644

Reviewed by Tyler Wilcock and Andres Gonzalez.

When we are mixing AX-thread text markers and main thread text markers, we
need to convert AXTextMarkers to CharacterPositions. CharacterPositions
are based on nodes, so using the root object (the ScrollView) will result
in a null CharacterPosition. Instead, let's use the WebArea which has an
associated node.

Ran against existing ax-thread-text-api/ tests that exercise startMarker.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::webArea):
(WebCore::AXIsolatedTree::firstMarker):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/284373@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications