[webkit-changes] [WebKit/WebKit] 39fbf6: REGRESSION(283632 at main): WKWebExtensionController ...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39fbf6d920eece9486860681112bd29f3900134b
      https://github.com/WebKit/WebKit/commit/39fbf6d920eece9486860681112bd29f3900134b
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M Source/WebKit/Shared/AuxiliaryProcess.cpp
    M Source/WebKit/Shared/AuxiliaryProcess.h
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h

  Log Message:
  -----------
  REGRESSION(283632 at main): WKWebExtensionController API tests assert
https://bugs.webkit.org/show_bug.cgi?id=280421
rdar://136770150

Reviewed by Chris Dumez and Timothy Hatcher.

Before 283632 at main, WebProcess would have manual IPC message handlers
which would log error and drop unhandled messages.

283632 at main would use the normal generated IPC message handlers, where
unhandled messages cause asserts.

Add the log + drop logic back to WebProcess.
dispatchMessage is the last step of the normal IPC message handling
process, so AuxiliaryProcess will filter out unhandled messages
for WebProcess, just before the assertions.

* Source/WebKit/Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::dispatchMessage):
(WebKit::AuxiliaryProcess::filterUnhandledMessage):
* Source/WebKit/Shared/AuxiliaryProcess.h:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::dispatchMessage):
(WebKit::WebProcess::filterUnhandledMessage):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/284360@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications