[webkit-changes] [WebKit/WebKit] 32780e: Only hyphenate text for which there is a language ...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 32780e4c841e62600407aea0f1ec6a6471b22e94
      https://github.com/WebKit/WebKit/commit/32780e4c841e62600407aea0f1ec6a6471b22e94
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/editing/spelling/spelling-marker-includes-hyphen-expected.html
    M LayoutTests/editing/spelling/spelling-marker-includes-hyphen.html
    M LayoutTests/fast/inline/hyphenation-when-overflow-wrap-is-break-word-expected.html
    M LayoutTests/fast/inline/hyphenation-when-overflow-wrap-is-break-word.html
    M LayoutTests/fast/text/simple-line-hyphens-with-text-align.html
    M LayoutTests/fast/text/simple-line-hyphens-with-word-letter-spacing.html
    M LayoutTests/fast/text/simple-line-layout-hyphen-limit-after.html
    M LayoutTests/fast/text/simple-line-layout-hyphen-limit-before.html
    M LayoutTests/fast/text/simple-line-layout-hyphen-limit-lines.html
    M LayoutTests/fast/text/simple-line-layout-hyphenation-constrains.html
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/gtk/fast/text/hyphenate-locale-expected.png
    M LayoutTests/platform/gtk/fast/text/hyphenate-locale-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png
    M LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt
    A LayoutTests/platform/wpe/fast/inline/hyphenation-when-overflow-wrap-is-break-word-expected.html
    A LayoutTests/platform/wpe/fast/text/simple-line-layout-hyphenation-constrains-expected.html
    A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-002-expected.html
    M Source/WebCore/platform/text/cf/HyphenationCF.cpp
    M Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp

  Log Message:
  -----------
  Only hyphenate text for which there is a language specified
https://bugs.webkit.org/show_bug.cgi?id=193003

Reviewed by Alex Christensen.

The spec https://drafts.csswg.org/css-text/#hyphens-property says:

"Authors should correctly tag their content’s language (e.g. using the
HTML lang attribute or XML xml:lang attribute) in order to obtain
correct automatic hyphenation."

There's also a dedicated WPT for this:
`imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html`

This patch makes WebKit follow the spec.

* LayoutTests/TestExpectations:
* LayoutTests/editing/spelling/spelling-marker-includes-hyphen-expected.html:
* LayoutTests/editing/spelling/spelling-marker-includes-hyphen.html:
* LayoutTests/fast/inline/hyphenation-when-overflow-wrap-is-break-word-expected.html:
* LayoutTests/fast/inline/hyphenation-when-overflow-wrap-is-break-word.html:
* LayoutTests/fast/text/simple-line-hyphens-with-text-align.html:
* LayoutTests/fast/text/simple-line-hyphens-with-word-letter-spacing.html:
* LayoutTests/fast/text/simple-line-layout-hyphen-limit-after.html:
* LayoutTests/fast/text/simple-line-layout-hyphen-limit-before.html:
* LayoutTests/fast/text/simple-line-layout-hyphen-limit-lines.html:
* LayoutTests/fast/text/simple-line-layout-hyphenation-constrains.html:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/gtk/fast/text/hyphenate-locale-expected.png:
* LayoutTests/platform/gtk/fast/text/hyphenate-locale-expected.txt:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png:
* LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt:
* LayoutTests/platform/wpe/fast/inline/hyphenation-when-overflow-wrap-is-break-word-expected.html: Added.
* LayoutTests/platform/wpe/fast/text/simple-line-layout-hyphenation-constrains-expected.html: Copied from LayoutTests/fast/text/simple-line-layout-hyphenation-constrains.html.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-text/hyphens/hyphenate-character-002-expected.html: Added.
* Source/WebCore/platform/text/cf/HyphenationCF.cpp:
(WebCore::canHyphenate):
* Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp:
(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):

Canonical link: https://commits.webkit.org/284355@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications