[webkit-changes] [WebKit/WebKit] 4672c5: [editing] Add offset range check in CompositeEditC...

ziransun noreply at github.com
Fri Sep 27 02:14:49 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4672c550c929439b3b291808899763bfc439e4ec
      https://github.com/WebKit/WebKit/commit/4672c550c929439b3b291808899763bfc439e4ec
  Author: Ziran Sun <zsun at igalia.com>
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/editing/CompositeEditCommand.cpp

  Log Message:
  -----------
  [editing] Add offset range check in CompositeEditCommand::replaceSelectedTextInNode().

https://bugs.webkit.org/show_bug.cgi?id=150969

Reviewed by Ryosuke Niwa and Darin Adler.

When replacing text in a text node, we need to valid the offset
range against the length of the text node. For example, in the
fixed test, the length of text node is 0, in which case, there is
no need to call replaceTextInNode() function.

* LayoutTests/TestExpectations:
* Source/WebCore/editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):

Canonical link: https://commits.webkit.org/284343@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list