[webkit-changes] [WebKit/WebKit] 31f319: WebKit needs to link to MediaExperience for AVSyst...

sambushell noreply at github.com
Thu Sep 26 14:42:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31f3194b191e140da29bb8edd76807fc5046a745
      https://github.com/WebKit/WebKit/commit/31f3194b191e140da29bb8edd76807fc5046a745
  Author: Sam Bushell <bushell at apple.com>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/ios/CelestialSPI.h
    M Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm
    M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

  Log Message:
  -----------
  WebKit needs to link to MediaExperience for AVSystemController, which lives there now
rdar://134522027
https://bugs.webkit.org/show_bug.cgi?id=279694

Reviewed by Eric Carlson and Jer Noble.

Explanation of why this fixes the bug:

These SPIs have moved (more than two years ago) and will be removed from their old location.  The change is a search-replace of Celestial with MediaExperience (private framework name) and from HAVE(CELESTIAL) to HAVE(MEDIAEXPERIENCE_AVSYSTEMCONTROLLER).

* Source/WebCore/PAL/pal/spi/ios/CelestialSPI.h:
* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:
(MediaSessionHelperIOS::providePresentingApplicationPID):
(-[WebMediaSessionHelper initWithCallback:]):
* Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::providePresentingApplicationPIDIfNecessary):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::exernalDeviceDisplayNameForPlayer):

Canonical link: https://commits.webkit.org/284313@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list