[webkit-changes] [WebKit/WebKit] 57a73a: [WPE][GTK] Handle EINTR in recvmsg() in IPC socket...

Povilas Kanapickas noreply at github.com
Thu Sep 26 02:38:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57a73ac7aa737d6fc8364eb591060f885923ee41
      https://github.com/WebKit/WebKit/commit/57a73ac7aa737d6fc8364eb591060f885923ee41
  Author: Povilas Kanapickas <povilas at radix.lt>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp

  Log Message:
  -----------
  [WPE][GTK] Handle EINTR in recvmsg() in IPC socket on Linux
https://bugs.webkit.org/show_bug.cgi?id=280366

Reviewed by Adrian Perez de Castro.

recvmsg() may fail with EINTR in case it is interrupted by a signal.
In the referred bug this happens due to a child process exiting (with a
zero exit code indicating success). This causes SIGCHLD signal which
just happens to occur during the time recvmsg was waiting for a message.
As recvmsg invocation has no handling for EINTR it will fail, bringing
down whole application with it.

Handling EINTR in a while loop is a canonical solution used in
many places across WebKit codebase already.

* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::readPIDFromPeer):

Canonical link: https://commits.webkit.org/284274@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list