[webkit-changes] [WebKit/WebKit] 2c6af0: [iOS] When VideoFullscreenRequiresElementFullscree...

aestes noreply at github.com
Wed Sep 25 22:44:16 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c6af0268355c9c268b16a216cb98b1d5ce08f09
      https://github.com/WebKit/WebKit/commit/2c6af0268355c9c268b16a216cb98b1d5ce08f09
  Author: Andy Estes <aestes at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLifecycle.mm

  Log Message:
  -----------
  [iOS] When VideoFullscreenRequiresElementFullscreen is enabled, pause video when exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=280286
rdar://136303710

Reviewed by Eric Carlson.

When VideoFullscreenRequiresElementFullscreen is enabled (but FullScreenEnabled is not), pause the
video when exiting fullscreen. This mimics how AVPlayerViewController behaves when exiting
fullscreen, which is a behavior some websites expect.

Added an API test.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController invalidate]):
(-[WKFullScreenViewController _pauseIfNeeded]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLifecycle.mm:
(TEST(Fullscreen, VideoPausesAfterExitingFullscreen)):

Canonical link: https://commits.webkit.org/284267@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list