[webkit-changes] [WebKit/WebKit] ccb1c3: REGRESSION(284236 at main): 16x TestWebKitAPI.Element...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccb1c37549a33d89557d5c84a09927651d341808
      https://github.com/WebKit/WebKit/commit/ccb1c37549a33d89557d5c84a09927651d341808
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebKit/Shared/API/APIObject.h
    M Source/WebKit/UIProcess/API/APITargetedElementRequest.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm

  Log Message:
  -----------
  REGRESSION(284236 at main): 16x TestWebKitAPI.ElementTargeting* (api-tests) are constant assertions
https://bugs.webkit.org/show_bug.cgi?id=280365
rdar://136715046

Reviewed by Abrar Rahman Protyasha and Geoffrey Garen.

Fix a latent issue in `_WKTargetedElementRequest`, which was caught by the debug assertion added in
284236 at main. Currently, we invoke `API::Object`'s copy constructor upon creating the wrapped API
object, which causes the `m_wrapper` to be `nil`.

* Source/WebKit/Shared/API/APIObject.h:
* Source/WebKit/UIProcess/API/APITargetedElementRequest.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm:
(-[_WKTargetedElementRequest init]):

Canonical link: https://commits.webkit.org/284253@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications