[webkit-changes] [WebKit/WebKit] 494de0: [JSC] Convert CheckStructure with String Structure...

Yusuke Suzuki noreply at github.com
Wed Sep 25 15:26:30 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 494de07b887e4a18400603824d12353e82754b1d
      https://github.com/WebKit/WebKit/commit/494de07b887e4a18400603824d12353e82754b1d
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
    M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp

  Log Message:
  -----------
  [JSC] Convert CheckStructure with String Structure etc. to Check(StringUse)
https://bugs.webkit.org/show_bug.cgi?id=280327
<rdar://problem/136659524>

Reviewed by Yijia Huang.

We found that CheckStructure(String structure) is not effectively
removed when abstract value is saying it is SpecString. We should
convert it to Check(StringUse) so that we can remove this based on more
coarse grained type information in abstract value. Also this patch does
it for SymbolUse and HeapBigIntUse too.

* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):

Canonical link: https://commits.webkit.org/284249@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list