[webkit-changes] [WebKit/WebKit] a27c02: Use SharedPreferencesForWebProcess in Model proces...

[Ada Chan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a27c02d607ead123026e5b83e6aa07497c632d58
      https://github.com/WebKit/WebKit/commit/a27c02d607ead123026e5b83e6aa07497c632d58
  Author: Ada Chan <adachan at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp
    M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.h
    M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.messages.in
    M Source/WebKit/ModelProcess/ModelProcess.cpp
    M Source/WebKit/ModelProcess/ModelProcess.h
    M Source/WebKit/ModelProcess/ModelProcess.messages.in
    M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.cpp
    M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h
    M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.messages.in
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
    M Source/WebKit/Shared/ModelProcessConnectionParameters.h
    M Source/WebKit/Shared/ModelProcessConnectionParameters.serialization.in
    M Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp
    M Source/WebKit/UIProcess/Model/ModelProcessProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  -----------
  Use SharedPreferencesForWebProcess in Model process and filter IPC messages by model element feature flag
https://bugs.webkit.org/show_bug.cgi?id=280277
rdar://123263852

Reviewed by Ryosuke Niwa and Mike Wyrzykowski.

Have ModelConnectionToWebProcess store a SharedPreferencesForWebProcess similar to how
it's done in GPUConnectionToWebProcess. Update WebPageProxy::preferencesDidChange to also
notify the model process of new shared preferences changes.

Use EnabledBy in model process message receivers to filter messages
based on the model element runtime feature flag.

* Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp:
(WebKit::m_sharedPreferencesForWebProcess):
(WebKit::m_presentingApplicationAuditToken): Deleted.
* Source/WebKit/ModelProcess/ModelConnectionToWebProcess.h:
(WebKit::ModelConnectionToWebProcess::sharedPreferencesForWebProcess const):
(WebKit::ModelConnectionToWebProcess::updateSharedPreferencesForWebProcess):
* Source/WebKit/ModelProcess/ModelConnectionToWebProcess.messages.in:
* Source/WebKit/ModelProcess/ModelProcess.cpp:
(WebKit::ModelProcess::sharedPreferencesForWebProcessDidChange):
* Source/WebKit/ModelProcess/ModelProcess.h:
* Source/WebKit/ModelProcess/ModelProcess.messages.in:
* Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.cpp:
(WebKit::ModelProcessModelPlayerManagerProxy::sharedPreferencesForWebProcess const):
* Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h:
* Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.messages.in:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::sharedPreferencesForWebProcess const):
* Source/WebKit/Shared/ModelProcessConnectionParameters.h:
* Source/WebKit/Shared/ModelProcessConnectionParameters.serialization.in:
* Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp:
(WebKit::ModelProcessProxy::sharedPreferencesForWebProcessDidChange):
* Source/WebKit/UIProcess/Model/ModelProcessProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::preferencesDidChange):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createModelProcessConnection):
(WebKit::WebProcessProxy::didSyncSharedPreferencesForWebProcessWithNetworkProcess):
(WebKit::WebProcessProxy::didSyncSharedPreferencesForWebProcessWithGPUProcess):
(WebKit::WebProcessProxy::didSyncSharedPreferencesForWebProcessWithModelProcess):
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/284246@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications