[webkit-changes] [WebKit/WebKit] f9961c: Debug assertion on https://www.browserbench.org/Mo...

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9961c9edb08ac769918287772cc1e0167c05918
      https://github.com/WebKit/WebKit/commit/f9961c9edb08ac769918287772cc1e0167c05918
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/SystemImage.h
    M Source/WebCore/platform/graphics/controls/ControlPart.h

  Log Message:
  -----------
  Debug assertion on https://www.browserbench.org/MotionMark1.3.1/developer.html
https://bugs.webkit.org/show_bug.cgi?id=280214

Reviewed by Said Abou-Hallawa.

When using threaded CPU rendering on WPE, clicking the  'Run Benchmark'
button on MotionMark developer.html fires an assertion. The ControlPart
object, associated with the button, is constructed during DisplayList
replay on a secondary thread, but destructed in the render tree teardown
phase during layout() on the main thread -- this leads to an assertion
in debug builds, that the construction/destruction thread is not
matched. Fix that by making ControlPart ThreadSafeRefCounted.

Covered by existing tests on WPE, in CPU rendering mode.

* Source/WebCore/platform/graphics/SystemImage.h:
* Source/WebCore/platform/graphics/controls/ControlPart.h:

Canonical link: https://commits.webkit.org/284244@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications