[webkit-changes] [WebKit/WebKit] 08514f: [JSC] Wasm compiler thread should be aligned with ...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 08514fe89587709edbb784598d987b3af5e15d7c
      https://github.com/WebKit/WebKit/commit/08514fe89587709edbb784598d987b3af5e15d7c
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmWorklist.cpp
    M Source/WTF/wtf/Threading.cpp

  Log Message:
  -----------
  [JSC] Wasm compiler thread should be aligned with other JIT compiler thread
https://bugs.webkit.org/show_bug.cgi?id=280342
rdar://136618735

Reviewed by Mark Lam.

1. Wasm compiler thread should be annotated as ThreadType::Compiler so
   that our stack size adjustment is applied to wasm compiler thread too.
2. It turned out that Wasm OMG compilation for each level is consuming
   enumerous amount of stack space 76KB in Debug build. We need to make
   stack height check more conservative.
3. Furthermore, anyway, it seems that Debug build of compiler code is
   taking significant amount of stack space regardless of whether it is
   using ASAN. We should extend the stack size as the same to ASAN
   build.

* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::canInline const):
* Source/JavaScriptCore/wasm/WasmWorklist.cpp:
* Source/WTF/wtf/Threading.cpp:
(WTF::stackSize):

Canonical link: https://commits.webkit.org/284232@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications