[webkit-changes] [WebKit/WebKit] 8bcc71: [Cleanup] Use block flow and writing mode consiste...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8bcc71f6c32cd99eab496c65e6a0fda868b3390a
      https://github.com/WebKit/WebKit/commit/8bcc71f6c32cd99eab496c65e6a0fda868b3390a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.h

  Log Message:
  -----------
  [Cleanup] Use block flow and writing mode consistently in BoxGeometryUpdater
https://bugs.webkit.org/show_bug.cgi?id=280090

Reviewed by Antti Koivisto.

Root container defines both the writing mode and the flow direction (which is derived from the writing mode). Let's not consult seemingly random parent boxes for these properties.
(Note that inline direction may change within the formatting context itself e.g. <div>ltr<span style="direction: rtl">rtl</span>ltr</div>)

* Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::BoxGeometryUpdater::horizontalLogicalMargin):
(WebCore::LayoutIntegration::BoxGeometryUpdater::verticalLogicalMargin):
(WebCore::LayoutIntegration::BoxGeometryUpdater::logicalBorder):
(WebCore::LayoutIntegration::BoxGeometryUpdater::logicalPadding):
(WebCore::LayoutIntegration::setIntegrationBaseline):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateInlineBoxDimensions):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateInlineContentConstraints):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateGeometryAfterLayout):
(WebCore::LayoutIntegration::BoxGeometryUpdater::isHorizontalWritingMode const):
(WebCore::LayoutIntegration::BoxGeometryUpdater::blockFlowDirection const):
(WebCore::LayoutIntegration::horizontalLogicalMargin): Deleted.
(WebCore::LayoutIntegration::verticalLogicalMargin): Deleted.
(WebCore::LayoutIntegration::logicalBorder): Deleted.
(WebCore::LayoutIntegration::logicalPadding): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.h:

Canonical link: https://commits.webkit.org/284223@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications