[webkit-changes] [WebKit/WebKit] 35740a: [Cleanup] Remove special "IsPartOfFormattingContex...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35740a4a8581f5317f2f6e5a9a0cfa73b7af12ed
      https://github.com/WebKit/WebKit/commit/35740a4a8581f5317f2f6e5a9a0cfa73b7af12ed
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h

  Log Message:
  -----------
  [Cleanup] Remove special "IsPartOfFormattingContext" handling from BoxGeometryUpdater
https://bugs.webkit.org/show_bug.cgi?id=280279

Reviewed by Antti Koivisto.

Let's just flip before/after border and padding values in BoxGeometryUpdater::updateInlineContentConstraints for the root
as this is temporary only (see comment).
-sadly this also requires moving table cell specific padding to the caller(s).

* Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::logicalBorder):
(WebCore::LayoutIntegration::logicalPadding):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateLineBreakBoxDimensions):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateInlineBoxDimensions):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateInlineContentConstraints):

Canonical link: https://commits.webkit.org/284218@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications