[webkit-changes] [WebKit/WebKit] 9e5342: [css-anchor-position-1] Parse anchor() as a calc()...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e5342da427ea97dfa23896043fa0bd0b20bb36b
      https://github.com/WebKit/WebKit/commit/9e5342da427ea97dfa23896043fa0bd0b20bb36b
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-invalid-fallback-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-query-custom-property-registration-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-typed-om-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/the-anchor-attribute-003.tentative-expected.txt
    M Source/WebCore/css/calc/CSSCalcTree+CalculationValue.cpp
    M Source/WebCore/css/calc/CSSCalcTree+ComputedStyleDependencies.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Copy.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Parser.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Simplification.h
    M Source/WebCore/css/calc/CSSCalcTree.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.h

  Log Message:
  -----------
  [css-anchor-position-1] Parse anchor() as a calc() function
https://bugs.webkit.org/show_bug.cgi?id=280191
rdar://136514213

Reviewed by Darin Adler and Sam Weinig.

Add calc tree node and parsing and serialization support for anchor().
The new code is only used in the calc(anchor(foo)) case for now, not with a top level anchor().

* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-invalid-fallback-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-query-custom-property-registration-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-typed-om-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/the-anchor-attribute-003.tentative-expected.txt:

New FAILs are in previously unimplemented feature.

* Source/WebCore/css/calc/CSSCalcTree+CalculationValue.cpp:
(WebCore::CSSCalc::toCalculationValue):
* Source/WebCore/css/calc/CSSCalcTree+ComputedStyleDependencies.cpp:
(WebCore::CSSCalc::collectComputedStyleDependencies):
* Source/WebCore/css/calc/CSSCalcTree+Copy.cpp:
(WebCore::CSSCalc::copy):
* Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp:
(WebCore::CSSCalc::evaluate):
* Source/WebCore/css/calc/CSSCalcTree+Parser.cpp:
(WebCore::CSSCalc::isCalcFunction):
(WebCore::CSSCalc::consumeAnchor):
(WebCore::CSSCalc::parseCalcFunction):
* Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp:
(WebCore::CSSCalc::serializeMathFunctionArguments):
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
(WebCore::CSSCalc::simplify):
(WebCore::CSSCalc::copyAndSimplifyChildren):
* Source/WebCore/css/calc/CSSCalcTree+Simplification.h:
* Source/WebCore/css/calc/CSSCalcTree.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.cpp:
(WebCore::CSSPropertyParserHelpers::consumeDashedIdentRaw):
(WebCore::CSSPropertyParserHelpers::consumeDashedIdent):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.h:

Canonical link: https://commits.webkit.org/284215@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications