[webkit-changes] [WebKit/WebKit] 608e68: [IsDeprecatedWeakRefSmartPointerException] Make We...

[Rupin Mittal]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 608e68962f08d8e1b0e05c26788b0b08e9552981
      https://github.com/WebKit/WebKit/commit/608e68962f08d8e1b0e05c26788b0b08e9552981
  Author: Rupin Mittal <rupin at apple.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/WebKit/Shared/XR/XRDeviceProxy.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp
    M Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h
    M Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.cpp
    M Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h
    M Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.cpp
    M Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.h

  Log Message:
  -----------
  [IsDeprecatedWeakRefSmartPointerException] Make WebProcess/XR and WebProcess/WebStorage files ref counted
https://bugs.webkit.org/show_bug.cgi?id=280231
rdar://136536190

Reviewed by Chris Dumez.

Remove IsDeprecatedWeakRefSmartPointerException. Since PlatformXRSystemProxy
has a single owner which does not re-assign it, we make PlatformXRSystemProxy
ref counted by adding ref() and deref() functions that forward the ref'ing to
the owner rather than making PlatformXRSystemProxy a subclass of RefCounted<>.

That's not the case for StorageAreaMap, so we make it subclass RefCounted.

* Source/WebKit/Shared/XR/XRDeviceProxy.cpp:
(WebKit::XRDeviceProxy::initializeTrackingAndRendering):
(WebKit::XRDeviceProxy::shutDownTrackingAndRendering):
(WebKit::XRDeviceProxy::didCompleteShutdownTriggeredBySystem):
(WebKit::XRDeviceProxy::requestFrame):
(WebKit::XRDeviceProxy::createLayerProjection):
(WebKit::XRDeviceProxy::submitFrame):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::xrSystemProxy):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::networkProcessConnectionClosed):
* Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::~StorageAreaImpl):
(WebKit::StorageAreaImpl::length):
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::item):
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::removeItem):
(WebKit::StorageAreaImpl::clear):
(WebKit::StorageAreaImpl::contains):
(WebKit::StorageAreaImpl::storageType const):
(WebKit::StorageAreaImpl::prewarm):
* Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h:
* Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
* Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h:
* Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.cpp:
(WebKit::PlatformXRSystemProxy::ref const):
(WebKit::PlatformXRSystemProxy::deref const):
* Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.h:

Canonical link: https://commits.webkit.org/284189@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications