[webkit-changes] [WebKit/WebKit] f036a1: [Win] WebCore/platform/win/SystemInfo.cpp: error: ...

Fujii Hironori noreply at github.com
Tue Sep 24 14:48:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f036a16b0d4e20409f928643119f3a0cce3a90d7
      https://github.com/WebKit/WebKit/commit/f036a16b0d4e20409f928643119f3a0cce3a90d7
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/win/SystemInfo.cpp

  Log Message:
  -----------
  [Win] WebCore/platform/win/SystemInfo.cpp: error: 'GetVersionExW' is deprecated
https://bugs.webkit.org/show_bug.cgi?id=280254

Reviewed by Ross Kirsling.

Without -Wno-deprecated-declarations, Windows port can't compile due
to the following warning:

> Source\WebCore\platform\win\SystemInfo.cpp(46,9): error: 'GetVersionExW' is deprecated [-Werror,-Wdeprecated-declarations]

Chromium ignores the warning for it.
<https://github.com/chromium/chromium/blob/9611525cd73157bf693c0c6c1fbc669649d067d8/base/win/windows_version.cc#L86-L94>

* Source/WebCore/platform/win/SystemInfo.cpp:
Ignore the warning for GetVersionEx.

Canonical link: https://commits.webkit.org/284183@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list