[webkit-changes] [WebKit/WebKit] 02cd89: REGRESSION (280914 at main): [macOS wk2] media/now-pl...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02cd89be8171c01f3c62bd167b4f030728e5c70a
      https://github.com/WebKit/WebKit/commit/02cd89be8171c01f3c62bd167b4f030728e5c70a
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M LayoutTests/media/now-playing-status-for-video-conference-web-page.html
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  REGRESSION (280914 at main): [macOS wk2] media/now-playing-status-for-video-conference-web-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=277024
rdar://132426511

Reviewed by Youenn Fablet.

NowPlayingState.haveEverRegisteredAsNowPlayingApplication is not consistently reset between tests, so do not rely
upon its value for testing purposes. Instead, add an Internals method that returns whether a specific media element
currently represents the "now playing session".

* LayoutTests/media/now-playing-status-for-video-conference-web-page.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isActiveNowPlayingSession const):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::elementIsActiveNowPlayingSession const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/284177@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications