[webkit-changes] [WebKit/WebKit] 7dd6ae: REGRESSION(283414 at main): [WPE][GTK] File descripto...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7dd6aeafdd8e4bf1e88de4f72bd39ad4d25ca5e6
      https://github.com/WebKit/WebKit/commit/7dd6aeafdd8e4bf1e88de4f72bd39ad4d25ca5e6
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
    M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp

  Log Message:
  -----------
  REGRESSION(283414 at main): [WPE][GTK] File descriptor leak if process launch is canceled immediately
https://bugs.webkit.org/show_bug.cgi?id=280073

Reviewed by Carlos Garcia Campos.

If the socket monitor callback is not called, the server socket is
leaked. Oops.

I am separately working on converting ProcessLauncher and
IPC::Connection to use UnixFileDescriptor, which will make errors like
this less likely. But that's a large change, and we should fix this
with a small change.

* Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp:
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:
* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::platformDestroy):
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/284159@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications