[webkit-changes] [WebKit/WebKit] 175731: [Cleanup] BoxGeometryUpdater::updateGeometryAfterL...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 175731ea2c2da3eae87c6e27781042b5ade50cff
      https://github.com/WebKit/WebKit/commit/175731ea2c2da3eae87c6e27781042b5ade50cff
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h

  Log Message:
  -----------
  [Cleanup] BoxGeometryUpdater::updateGeometryAfterLayout should really only update content box size
https://bugs.webkit.org/show_bug.cgi?id=280164

Reviewed by Antti Koivisto.

Margin, border and padding values are already computed before calling back on the render tree for layout.
updateGeometryAfterLayout, in theory should only update the content box size, in practice though we still need to run some
adjustment on various properties (e.g. baseline, list marker offset), but they eventually gonna go away.

This is also in preparation for moving all "sizing" logic from renderers over to BoxGeometryUpdater (surely needs a rename) where we call layoutWithFormattingContextForBox only to initiate layout on formatting context roots.

* Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::logicalPadding):
(WebCore::LayoutIntegration::setIntegrationBaseline):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::BoxGeometryUpdater::setGeometriesForLayout):
(WebCore::LayoutIntegration::BoxGeometryUpdater::updateGeometryAfterLayout):
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::BoxGeometry::setSpaceForScrollbar):

Canonical link: https://commits.webkit.org/284154@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications