[webkit-changes] [WebKit/WebKit] bddc4d: [GTK][WPE] IPC::Connection fails to unset FD_CLOEXEC

[Jani Hautakangas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bddc4d06811ac1d7164c5ebd230792d204648b6f
      https://github.com/WebKit/WebKit/commit/bddc4d06811ac1d7164c5ebd230792d204648b6f
  Author: Jani Hautakangas <jani at igalia.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/WTF/wtf/unix/UniStdExtrasUnix.cpp

  Log Message:
  -----------
  [GTK][WPE] IPC::Connection fails to unset FD_CLOEXEC
https://bugs.webkit.org/show_bug.cgi?id=280256

Reviewed by Carlos Garcia Campos.

There's a logic error in UniStdExtrasUnix.cpp where unsetCloseOnExec(int)
expects fnctl(...) F_GETFD to return -1 as a flags value before trying to
remove FD_CLOEXEC flag. However, -1 indicates error so FD_CLOEXEC never gets
removed and calling function in ConnectionUnix createPlatformConnection has
RELEASE_ASSERT which leads to crash.

unsetCloseOnExec should check if fnctl(...) F_GETFD return value is
!= -1 before setting new flag value.

* Source/WTF/wtf/unix/UniStdExtrasUnix.cpp:
(WTF::unsetCloseOnExec):

Canonical link: https://commits.webkit.org/284153@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications