[webkit-changes] [WebKit/WebKit] d5f431: [CoordinatedGraphics] Simplify image backing store...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5f431c113d60c7b98c1042ef22f236685a1ce51
      https://github.com/WebKit/WebKit/commit/d5f431c113d60c7b98c1042ef22f236685a1ce51
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/SourcesNicosia.txt
    M Source/WebCore/platform/TextureMapper.cmake
    M Source/WebCore/platform/graphics/nicosia/NicosiaCompositionLayer.h
    R Source/WebCore/platform/graphics/nicosia/NicosiaImageBacking.cpp
    R Source/WebCore/platform/graphics/nicosia/NicosiaImageBacking.h
    R Source/WebCore/platform/graphics/nicosia/NicosiaImageBackingStore.cpp
    R Source/WebCore/platform/graphics/nicosia/NicosiaImageBackingStore.h
    M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp
    M Source/WebCore/platform/graphics/texmap/GraphicsLayerAsyncContentsDisplayDelegateTextureMapper.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerCairo.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp
    A Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBackingStore.cpp
    A Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBackingStore.h
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferNativeImage.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferNativeImage.h
    M Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp
    M Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h

  Log Message:
  -----------
  [CoordinatedGraphics] Simplify image backing store handling
https://bugs.webkit.org/show_bug.cgi?id=280173

Reviewed by Miguel Gomez.

Add a CoordinatedImageBackingStore that uses a
CoordinatedPlatformLayerBufferNativeImage as the buffer. This way we
don't need to paint the image to get a Nicosia::Buffer, we can just
paint the buffer into the texture mapper when compositing.

* Source/WebCore/platform/SourcesNicosia.txt:
* Source/WebCore/platform/TextureMapper.cmake:
* Source/WebCore/platform/graphics/nicosia/NicosiaCompositionLayer.h:
* Source/WebCore/platform/graphics/nicosia/NicosiaImageBacking.cpp: Removed.
* Source/WebCore/platform/graphics/nicosia/NicosiaImageBacking.h: Removed.
* Source/WebCore/platform/graphics/nicosia/NicosiaImageBackingStore.cpp: Removed.
* Source/WebCore/platform/graphics/nicosia/NicosiaImageBackingStore.h: Removed.
* Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp:
(WebCore::ImageBufferSkiaAcceleratedBackend::ImageBufferSkiaAcceleratedBackend):
* Source/WebCore/platform/graphics/texmap/GraphicsLayerAsyncContentsDisplayDelegateTextureMapper.cpp:
(WebCore::GraphicsLayerAsyncContentsDisplayDelegateTextureMapper::tryCopyToLayer):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
(WebCore::CoordinatedGraphicsLayer::usesContentsLayer const):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerCairo.cpp:
(WebCore::CoordinatedGraphicsLayer::paintImage): Deleted.
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp:
(WebCore::CoordinatedGraphicsLayer::paintImage): Deleted.
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBackingStore.cpp: Added.
(WebCore::CoordinatedImageBackingStore::create):
(WebCore::CoordinatedImageBackingStore::CoordinatedImageBackingStore):
(WebCore::CoordinatedImageBackingStore::uniqueIDForNativeImage):
(WebCore::CoordinatedImageBackingStore::isSameNativeImage):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBackingStore.h: Added.
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferNativeImage.cpp:
(WebCore::CoordinatedPlatformLayerBufferNativeImage::create):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayerBufferNativeImage.h:
* Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::updateSceneState):
(WebKit::CoordinatedGraphicsScene::purgeGLResources):
(WebKit::updateImageBacking): Deleted.
* Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::imageBackingStore):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

Canonical link: https://commits.webkit.org/284151@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications