[webkit-changes] [WebKit/WebKit] a5be09: Move m_openerFrame from WebPageProxy to WebFrameProxy

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5be0951ab3fccf028d9f85af53c6962726be3dc
      https://github.com/WebKit/WebKit/commit/a5be0951ab3fccf028d9f85af53c6962726be3dc
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/WebFrameProxy.cpp
    M Source/WebKit/UIProcess/WebFrameProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Move m_openerFrame from WebPageProxy to WebFrameProxy
https://bugs.webkit.org/show_bug.cgi?id=279778
rdar://136100596

Reviewed by Charlie Wolfe.

Storing the opener on the WebPageProxy is conceptually incorrect.
Although most of the time the main frame has an opener, but with
window.open with a named frame target any frame can have an opener.

I also cleaned up a few places where we prevent suspending a process
after window.open is called with site isolation on.  They were needed
before BrowsingContextGroup existed but not any more.

* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::didCreateSubframe):
* Source/WebKit/UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::create):
(WebKit::WebFrameProxy::opener):
(WebKit::WebFrameProxy::disownOpener):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::suspendCurrentPageIfPossible):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::shouldClosePreviousPage):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::creationParameters):
(WebKit::openerFrame): Deleted.
(WebKit::WebPageProxy::openerPage const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):

Canonical link: https://commits.webkit.org/284139@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications