[webkit-changes] [WebKit/WebKit] 8defcb: [ITP] Refactor logic for managing the lifetimes of...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8defcbeb9bbafc2a135b9b5cd4703fdccb289335
      https://github.com/WebKit/WebKit/commit/8defcbeb9bbafc2a135b9b5cd4703fdccb289335
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M Source/WebCore/loader/CookieJar.cpp
    M Source/WebCore/loader/CookieJar.h
    M Source/WebCore/storage/Storage.cpp
    M Source/WebCore/storage/Storage.h
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.h
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

  Log Message:
  -----------
  [ITP] Refactor logic for managing the lifetimes of script-written third party cookies and local storage
https://bugs.webkit.org/show_bug.cgi?id=280099
rdar://136378432

Reviewed by Charlie Wolfe.

Add checks for script telemetry underneath calls to read from or write to `localStorage` or
`document.cookie`.

* Source/WebCore/loader/CookieJar.cpp:
(WebCore::CookieJar::getRawCookies const):
* Source/WebCore/loader/CookieJar.h:
* Source/WebCore/storage/Storage.cpp:
(WebCore::Storage::length const):
(WebCore::Storage::key const):
(WebCore::Storage::getItem const):
(WebCore::Storage::setItem):
(WebCore::Storage::removeItem):
(WebCore::Storage::requiresScriptExecutionTelemetry const):
* Source/WebCore/storage/Storage.h:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::requiresScriptExecutionTelemetry):
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::setCookies):
(WebKit::WebCookieJar::cookiesEnabled):
(WebKit::WebCookieJar::cookieRequestHeaderFieldValue const):
(WebKit::WebCookieJar::getRawCookies const):
(WebKit::WebCookieJar::getCookiesAsync const):
(WebKit::WebCookieJar::setCookieAsync const):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[WKWebView synchronouslyLoadSimulatedRequest:responseHTMLString:]):

Add a helper method to synchronously load a simulated `NSURLRequest`.

Canonical link: https://commits.webkit.org/284135@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications